Hi Nirmal,

Dave's question below prompted me to think of a couple of
questions on the proposed bug fix:

1) Since size is now optional,  I can have more than 1 zvol
where I don't specify the size.  Based on your fix, each of those
zvols that does not have a size will get 90% of the zpool size. That obviously
won't work.  How would this situation be handled?

2) A related question, if I specify a zpool that have both ZFS filesystems
and a zvol where I didn't specify a size, is it necessary for us to warn the
user that the ZFS filesystem that will be created will only be 10% size of the pool.

Thanks,

--Karen

On 02/14/12 08:28, Nirmal Agarwal wrote:
Hi Dave

I did test the full installation and it works.

Let me know if you want to run any other tests.

Thanks
Nirmal


On 02/14/12 03:22, Dave Miner wrote:
I haven't reviewed the code here, but can you elaborate on the testing?
Does AI create a correctly usable swap volume, and will Solaris boot
with that swap volume once you've done so? It's not entirely clear to me
that this will work.

Dave

On 02/13/12 00:12, Nirmal Agarwal wrote:
Hi all

Could I please get a code review for the following CR:

7070697 size element for zvols should be optional

Webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7070697/webrev/

slim_test result
----------------
/net/indiana-build.us.oracle.com//export/home/na210770/ai/7070697/slim_test


Manual Tests :

-- created a custom image and tested the fix with the manifest not
describing the size of zvol.


Thanks
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to