Hi Nirmal,

Thanks for the explanation, now, I understand why creating
a separate Filesystem object is necessary.

I have a couple of questions about this fix that
popped up based on Dave's comment.  I will ask my questions in
that email.

Thanks,

--Karen

On 02/14/12 08:25, Nirmal Agarwal wrote:
Hi Karen

I tried to use the zpool "free" property in place of zfs dataset's "available" property.

I did a small test with zpool and zfs properties.

root@lbl-643:/var/tmp# mkfile  64m test.fil
root@lbl-643:/var/tmp# zpool create testpool /var/tmp/test.fil
root@lbl-643:/var/tmp# zpool get free testpool
NAME      PROPERTY  VALUE  SOURCE
testpool  free      58.9M  -
root@lbl-643:/var/tmp# zfs list testpool
NAME      USED  AVAIL  REFER  MOUNTPOINT
testpool   85K  26.9M    31K  /testpool
root@lbl-643:/var/tmp# df -h /testpool
Filesystem             Size   Used  Available Capacity  Mounted on
testpool                27M    31K        27M     1%    /testpool

As you can see there is a large discrepancy between the zpool "free" value and "available" value of zfs.
This behavior can be explained considering the "free" doesn't count
"reserved space" for a pool which is 1/64 or 32MB whichever is greater.
[Thanks to Drew for helping me in understanding this.]

Thanks
Nirmal

On 02/14/12 01:03, Karen Tung wrote:
Hi Nirmal,

I have a question about your changes.

usr/src/lib/install_target/logical.py, line 711-712, why do you need to
create
another Filesystem object in 711 for getting the size?
self.parent is a Zpool object, can you get the size from that?

Thanks,

--Karen


On 02/12/12 09:12 PM, Nirmal Agarwal wrote:
Hi all

Could I please get a code review for the following CR:

7070697 size element for zvols should be optional

Webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7070697/webrev/

slim_test result
----------------
/net/indiana-build.us.oracle.com//export/home/na210770/ai/7070697/slim_test


Manual Tests :

-- created a custom image and tested the fix with the manifest not
describing the size of zvol.


Thanks
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss



_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to