John,
In auto_install.py, the changes at lines 183, 220, 648, 738, 760, 763,
907 will cause these lines to show up on the screen for zone installs,
which we don't want. I don't have any better suggestions than to revert
them back to debug at this point.
560, 582, 667 are now debug, but I think they should stay info. When we
use manually use auto-install to debug with the pause/resume flags, I
think we want to be notified with those messages on stdout.
703 - Any reason why this was changed to debug? info seems more
appropriate.
thanks,
-ethan
On 03/01/12 17:37, John Fischer wrote:
All,
Can I get a code review for:
7097012 AI should output to /dev/console as well as
/system/volatile/install_log
http://monaco.us.oracle.com/detail.jsf?cr=7097012
The webrev is located at:
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7097012-AI-output-console/
The basic fix is to have all checkpoints produce output. This is done
by passing in
a kwargs show_output to engine.register_checkpoint(). In addition to
this fix I have
cleaned up the output for AI changing several things from debug to
info and visa versa.
Furthermore, there was some duplicate output during the early stages
due to fractional
percents. This was fixed by saving the previous non-time progress and
comparing it
with the current non-time progress.
I have built an AI iso image using distro_const, setup and installed a
new host. Ethan
checked on a zones setup. I also ran the test suite. All testing was
as expected. The
code is pep8 and pylint clean, improved or unchanged.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
