John,
I think you missed reverting two lines: 224 and 230. Other than that,
looks ok.
-ethan
On 03/10/12 07:07, John Fischer wrote:
Ethan,
See comments below. Essentially I have reverted all the messages as
suggested.
The new webrev is located at:
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7097012-AI-output-console-3
https://cr.opensolaris.org/action/browse/caiman/johnfisc/7097012-AI-output-console-3dif
The CR may be viewed at:
7097012 AI should output to /dev/console as well as
/system/volatile/install_log
http://monaco.us.oracle.com/detail.jsf?cr=7097012
Thanks,
John
On 03/ 6/12 03:06 PM, Ethan Quach wrote:
In auto_install.py, the changes at lines 183, 220, 648, 738, 760,
763, 907 will cause these lines to show up on the screen for zone
installs, which we don't want. I don't have any better suggestions
than to revert them back to debug at this point.
Neither do I. I have reverted them back.
560, 582, 667 are now debug, but I think they should stay info. When
we use manually use auto-install to debug with the pause/resume
flags, I think we want to be notified with those messages on stdout.
My thought was that these should be only sent to debug because the
pause/resume flags
are not documented (i.e., private). However, I have reverted them back.
703 - Any reason why this was changed to debug? info seems more
appropriate.
D'oh. I agree 100%. Reverted to info as well.
thanks,
-ethan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
