Looks good. Thanks,
Darren. On 12/03/2012 19:56, Ethan Quach wrote: > Darren, > > Thanks for taking a look. FYI, I just updated the webrev with one new > change in ai_manifest.4 that corrects the description of whole_disk > behavior. It is in ai_manifest.4: line 683. > > > thanks, > -ethan > > > On 03/12/12 05:58, Darren Kenny wrote: >> Hi Ethan, >> >> Hard to do the comparison here alright :-S >> >> I took a read through, as best I could, I feel everything looks good... >> >> But it would certainly be good to have at least 1 or two more sets of eyes >> to be sure. >> >> Thanks, >> >> Darren. >> >> On 11/03/2012 03:04, Ethan Quach wrote: >>> Hi all, >>> >>> Can I get a code review of the following bugs. These are on behalf of Alta. >>> >>> The fix in ai_manifest.4 is mainly to get its nroff'ed version into the >>> gate now so that subsequent reviews will be easier. The changes this time >>> does include a couple other fixes in that file. The lines that are >>> pertinent to look at for those are 2040-2052, and 1861-1862, and 2292. >>> >>> BugIDs: >>> ===== >>> >>> ai_manifest.4 >>> ----------------- >>> 7068503<http://monaco.us.oracle.com/detail.jsf?cr=7068503> Update >>> slim_source ai_manifest(4) manpage to nroff version >>> 7105779<http://monaco.us.oracle.com/detail.jsf?cr=7105779> ai_manifest(4) >>> has inaccurate example >>> >>> installadm.1m >>> ------------------ >>> 7130028<http://monaco.us.oracle.com/detail.jsf?cr=7130028> all_service >>> properties need to be documented in installadm man page >>> 7127533<http://monaco.us.oracle.com/detail.jsf?cr=7127533> installadm(1m) >>> templating example needs updating >>> 7127320<http://monaco.us.oracle.com/detail.jsf?cr=7127320> Fix for CR >>> 7090169 requires changes in the install documentation >>> >>> js2ai.1m >>> ----------- >>> 7148033<http://monaco.us.oracle.com/detail.jsf?cr=7148033> js2ai.1m: >>> update steps in how root disk and root pool are determined >>> 7109214<http://monaco.us.oracle.com/detail.jsf?cr=7109214> js2ai man page >>> needs updated to reflect recent changes >>> >>> >>> Webrev: >>> ===== >>> https://cr.opensolaris.org/action/browse/caiman/equach/manpages/webrev/ >>> >>> >>> thanks, >>> -ethan >>> >>> >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
