On 03/13/12 04:24 PM, Ethan Quach wrote:
Darren, Sue, Kristina,
Thanks for the review.
Sue, could I ask you to re-review installadm.1m? It now contains the changes
for the following two
fixes:
7114457 <http://monaco.us.oracle.com/detail.jsf?cr=7114457> installadm manpage
should be updated to
reflect update-profile subcommand for installadm (CR7041537)
7112705 <http://monaco.us.oracle.com/detail.jsf?cr=7112705> update installadm
man page to include
new imagepath option for set-service subcommand
and incremental changes for 7130028
<http://monaco.us.oracle.com/detail.jsf?cr=7130028>.
The original webrev is updated, but an incremental webrev is also here:
https://cr.opensolaris.org/action/browse/caiman/equach/manpages-diff2/webrev/
553 Says:
where \fBall_services/default_imagepath_basedir\fR is a property
that you can set as shown in "Install Server Configuration Properties."
but it does not really tell you anything about setting that property in that
section.
Also, not related to these changes, I noticed that in example 3, we use the word "source" when
referring to the publisher:
To specify the source of the \fBsolaris-auto-install\fR package, use the \fB-p\fR option. This might
cause confusion since we use --source as a different option to create-service:
[-s|--source \fIFMRI_or_ISO\fR].
Might be worth changing either now or in a future update to the manpage.
Sue
Also, the following two bugs were actually addressed in the original webrev, so
I've added them to
the CR list:
7109854 <http://monaco.us.oracle.com/detail.jsf?cr=7109854> ai_manifest manpage
describes SVR4
package installation incorrectly
7114896 <http://monaco.us.oracle.com/detail.jsf?cr=7114896> installadm manpage
should show
"hostname" as criteria for manifest
thanks,
-ethan
On 03/10/12 19:04, Ethan Quach wrote:
Hi all,
Can I get a code review of the following bugs. These are on behalf of Alta.
The fix in ai_manifest.4 is mainly to get its nroff'ed version into the gate
now so that
subsequent reviews will be easier. The changes this time does include a couple
other fixes in that
file. The lines that are pertinent to look at for those are 2040-2052, and
1861-1862, and 2292.
BugIDs:
=====
ai_manifest.4
-----------------
7068503 <http://monaco.us.oracle.com/detail.jsf?cr=7068503> Update slim_source
ai_manifest(4)
manpage to nroff version
7105779 <http://monaco.us.oracle.com/detail.jsf?cr=7105779> ai_manifest(4) has
inaccurate example
installadm.1m
------------------
7130028 <http://monaco.us.oracle.com/detail.jsf?cr=7130028> all_service
properties need to be
documented in installadm man page
7127533 <http://monaco.us.oracle.com/detail.jsf?cr=7127533> installadm(1m)
templating example
needs updating
7127320 <http://monaco.us.oracle.com/detail.jsf?cr=7127320> Fix for CR 7090169
requires changes in
the install documentation
js2ai.1m
-----------
7148033 <http://monaco.us.oracle.com/detail.jsf?cr=7148033> js2ai.1m: update
steps in how root
disk and root pool are determined
7109214 <http://monaco.us.oracle.com/detail.jsf?cr=7109214> js2ai man page
needs updated to
reflect recent changes
Webrev:
=====
https://cr.opensolaris.org/action/browse/caiman/equach/manpages/webrev/
thanks,
-ethan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
