Nirmal: Can also check about pylint also besides pep8 ??? Thanks !!!
----- Original Message ----- From: [email protected] To: [email protected] Sent: Thursday, March 15, 2012 5:46:13 AM GMT -08:00 Tijuana / Baja California Subject: [caiman-discuss] Code review for 7070697 [Round 2] Hi all Could I please get a code review for the following CR: 7070697 size element for zvols should be optional Webrev : https://cr.opensolaris.org/action/browse/caiman/nirmal27/7070697-4/webrev/ Fix : --> new value "max" for zvol size attribute introduced which will create zvol with 90% of the free space in the pool. --> "max" value is allowed only for "swap" zvols. --> We cannot have multiple zvols with "max" value in the same pool. slim_test result ---------------- /net/indiana-build.us.oracle.com//export/home/na210770/ai/7070697/slim-test Source is pep8 clean. Testing : I have done following tests with custom image : 1) Zvol with "max" value . It succeeds. 2) 2 Zvol with "max" value in the same pool. It fails. 3) Zvol with "max" value and not defined as "swap" . It fails. 4) 2 Zvol with "max" size subelement in different pools. It succeeds. Also added new unit tests to verify zvol creation with "max" value. Thanks Nirmal _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
