Hi Nirmal,
On 03/15/12 01:56 PM, Nirmal Agarwal wrote:
Hi Karen
Please find my reply inline.
On 3/15/2012 9:39 PM, Karen Tung wrote:
Hi Nirmal,
When you filed the RTI for this fix a few weeks ago, I remembered
Sanjay was concerned about allocating 90% of the space on
a huge multi-terabyte zpool. I remembered that you were going to
cap the size for "max" if the pool size
is above a certain value. I do not see that implemented in this webrev,
do we not worry about that case now?
In earlier implementation, if user doesn't provide meant that allocate
the maximum size available to zvol. In this approach, intention of the
user was not very clear.
So as per the suggestion and current approach , if user specify "max"
as value of size we should not try to limit the size to a predefined
value allowing him to create max
possible size zvol.
OK. Thanks for the explanation.
Also, bug 7070697 listed 2 problems. The fix you have now will only
address the problem reported in entry #1 of the description. Can you
file
a separate bug for the problem in entry #2? That way, the problem
can be fixed separately.
I will file a separate CR for the same and fix it.
Sounds good.
I have no further comment on this fix.
Thanks,
--Karen
Regards
Nirmal
Thanks,
--Karen
On 03/15/12 06:36, Nirmal Agarwal wrote:
Hi all
Could I please get a code review for the following CR:
7070697 size element for zvols should be optional
Webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7070697-4/webrev/
Fix :
--> new value "max" for zvol size attribute introduced which will
create zvol with 90% of the free space in the pool.
--> "max" value is allowed only for "swap" zvols.
--> We cannot have multiple zvols with "max" value in the same pool.
slim_test result
----------------
/net/indiana-build.us.oracle.com//export/home/na210770/ai/7070697/slim-test
Source is pep8 clean.
Testing :
I have done following tests with custom image :
1) Zvol with "max" value . It succeeds.
2) 2 Zvol with "max" value in the same pool. It fails.
3) Zvol with "max" value and not defined as "swap" . It fails.
4) 2 Zvol with "max" size subelement in different pools. It succeeds.
Also added new unit tests to verify zvol creation with "max" value.
Thanks
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
