Harold:
My comment are nits anyway and related to pylint:
1.
https://cr.opensolaris.org/action/browse/caiman/hshaw/7149189/webrev/raw_files/new/usr/src/cmd/distro_const/checkpoints/pre_pkg_img_mod.py
Should get rid of the unused import of Popen on line 42.
2.
https://cr.opensolaris.org/action/browse/caiman/hshaw/7149189/webrev/raw_files/new/usr/src/cmd/installadm/image.py
The following lines should be removed since pylint complains about
reimport warning from line 56 to line 58:
import pkg.client.imageconfig
import pkg.client.imagetypes
import pkg.client.progress
They are already imported from line 62:
from osol_install.auto_install.installadm_common import _, cli_wrap as cw
On 03/20/12 14:34, Harold Shaw wrote:
Can I get a code review for the following bug:
CR: http://monaco.sfbay/detail.jsf?cr=7149189
Webrev:https://cr.opensolaris.org/action/browse/caiman/hshaw/7149189
Testing:
pep8 clean
distro_const checkpoint unit tests have been run
Attempt to create an AI service from:
- text UI & live CD created with DC changes (error out)
- S11U1_11 text UI & live CD ISO's (from nana) (error out)
- AI ISO created with DC changes (successful)
Verified that the .image_info file contains the expected
IMAGE_TYPE line
- S11U1_11 AI ISO (from nana) (successful)
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
