Thanks, John. Comments inline.
Harold
On 04/09/12 11:41, John Fischer wrote:
Harold,
Thanks for making this change and the patience.
usr/src/cmd/installadm/image.py
- Should image_type() be decorated with @property?
85 def image_type(self):
That way the check:
114 self.image_type() == "AI"))):
could be 'self.image_type == "AI".
Good suggestion. I will do that.
Does a test need to be created to exercise this part
of the code?
I will add a couple of tests to the image test part of the installadm
unit tests. I will send out a code review when complete.
Thanks,
John
On 03/20/12 02:34 PM, Harold Shaw wrote:
Can I get a code review for the following bug:
CR: http://monaco.sfbay/detail.jsf?cr=7149189
Webrev:https://cr.opensolaris.org/action/browse/caiman/hshaw/7149189
Testing:
pep8 clean
distro_const checkpoint unit tests have been run
Attempt to create an AI service from:
- text UI & live CD created with DC changes (error out)
- S11U1_11 text UI & live CD ISO's (from nana) (error out)
- AI ISO created with DC changes (successful)
Verified that the .image_info file contains the expected
IMAGE_TYPE line
- S11U1_11 AI ISO (from nana) (successful)
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
