Darren: My comments are nits and it is related to pylint warning:
W0105 - String statement has no effect The following lines had complains: 427 except api_errors.CatalogRefreshException, cre: 428 '''Handle CatalogRefreshException especially since it doesn't 429 pretty-print it's contents in a __str__() impl. 430 ''' 431 raise RuntimeError(self.catalog_failures_to_str(cre)) If you change them to comments, then the pylint warning go away: 428 # Handle CatalogRefreshException especially since it doesn't 429 # pretty-print it's contents in a __str__() impl. ----- Original Message ----- From: [email protected] To: [email protected] Cc: [email protected], [email protected] Sent: Friday, March 23, 2012 9:27:12 AM GMT -08:00 US/Canada Pacific Subject: Re: [caiman-discuss] CR Request for bug 7152537 AI fails to install packages with licenses using must-display=true and not must-accept=true LGTM! -Drew On 3/23/12 10:07 AM, Darren Kenny wrote: > Of course worth including the webrev: > > https://cr.opensolaris.org/action/browse/caiman/dkenny/7152537/webrev/ > > Thanks, > > Darren. > > On 23/03/2012 16:04, Darren Kenny wrote: >> Hi, >> >> Could I please, again, get a code review for the change for bug: >> >> 7152537 AI fails to install packages with licenses using >> must-display=true and not must-accept=true >> >> I'm still in the process of re-testing, but would like to get the code >> review done. >> >> I separated this out from the implementation of the RFE 7145997 since it >> shouldn't be held up due to more work being required on that RFE. >> >> Thanks, >> >> Darren. >> >> _______________________________________________ >> caiman-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
