Hi Drew,
Thanks for the review...
For the record, there was an omission in the last webrev, where I didn't
patch the two variables:
63 +LICENSE_ACCEPTED = "automatically accepted"
64 +LICENSE_NOT_DISP = "not displayed"
65 +
at the top of the file.
FYI, yhe new webrev is at:
https://cr.opensolaris.org/action/browse/caiman/dkenny/7152537-2/webrev
Thanks,
Darren.
On 23/03/2012 16:25, Drew Fisher wrote:
> LGTM!
>
> -Drew
>
> On 3/23/12 10:07 AM, Darren Kenny wrote:
>> Of course worth including the webrev:
>>
>> https://cr.opensolaris.org/action/browse/caiman/dkenny/7152537/webrev/
>>
>> Thanks,
>>
>> Darren.
>>
>> On 23/03/2012 16:04, Darren Kenny wrote:
>>> Hi,
>>>
>>> Could I please, again, get a code review for the change for bug:
>>>
>>> 7152537 AI fails to install packages with licenses using
>>> must-display=true and not must-accept=true
>>>
>>> I'm still in the process of re-testing, but would like to get the code
>>> review done.
>>>
>>> I separated this out from the implementation of the RFE 7145997 since it
>>> shouldn't be held up due to more work being required on that RFE.
>>>
>>> Thanks,
>>>
>>> Darren.
>>>
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> [email protected]
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>> _______________________________________________
>> caiman-discuss mailing list
>> [email protected]
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
