Hi all

Can I please get a code review for CR 6996539.

6996539 Convert AI to use ipadm instead of ifconfig


Webrev :
https://cr.opensolaris.org/action/browse/caiman/nirmal27/6996539/webrev/

I have removed get_ip_netmask() and find_network_nmask() from
installadm-common.sh. I couldn't find reference to them in the gate.
Let me know if I missed something.

Pep8 is clean and pylint output is unchanged.

Testing :

-> Created custom image and tested client boots and sets the
   criteria correctly.

--> installed the installadm packages from nightly and created
    a service.

Let me know if I need to run some other tests.

Thanks
Nirmal
_______________________________________________
caiman-discuss mailing list
caiman-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to