Jack: Thanks. Will do so.
----- Original Message ----- From: [email protected] To: [email protected] Cc: [email protected] Sent: Friday, April 13, 2012 9:24:05 AM GMT -08:00 Tijuana / Baja California Subject: Re: [caiman-discuss] code review request for 7144255 HI Mary. Most looks fine. I have only one remaining comment: >> 78: How come setting the environment needs to be run with sudo? The >> environment should be settable as a normal user, and will be >> inherited by subprocesses later. >> > > From my notes with Keith, we need to run slim_test with root > priviledges. So setting the environment with sudo will automatically > get you root priviledge. I investigated this further. You are correct that /opt/onbld/bin/bldenv needs sudo. But... bldenv opens up a new shell which has root privilege, when run with sudo. So you don't need to invoke sudo when running slim_test from that new shell. Lines 89, 92,95, 101 and any others which invoke slim_test can do so without sudo. To check this out, invoke bldenv with sudo, and observe that the prompt will change to a #. waterloo2:/export/home/jacschwa> sudo /opt/onbld/bin/bldenv -d ./setup.sh Build type is DEBUG RELEASE is VERSION is 5.11 RELEASE_DATE is April 2012 Using /bin/bash as shell. root@waterloo2:/export/home/jacschwa# id -a uid=0(root) gid=0(root) groups=0(root),1(other),2(bin),3(sys),4(adm),5(uucp),6(mail),7(tty),8(lp),9(nuucp),12(daemon) root@waterloo2:/export/home/jacschwa# exit waterloo2:/export/home/jacschwa> Thanks, Jack > >> Thanks, >> Jack >> >> On 04/11/12 02:00 PM, Mary Ding wrote: >>> Hi: >>> >>> Can I get a quick review for the following CR to update >>> usr/src/README and usr/src/tools/tests/README: >>> >>> >>> 7144255 <http://monaco.us.oracle.com/detail.jsf?cr=7144255> Need to >>> update usr/src/tools/tests/README and usr/src/README about http >>> proxy/nosexunit/pylint/nose >>> >>> The webrev is here: >>> >>> https://cr.opensolaris.org/action/browse/caiman/md5645/7144255 >>> >>> >>> Testing had been done as follow: >>> >>> 1. I installed nose 1.0.0 on tcu27-01 and install_unit_tests had no >>> failures: >>> >>> http://indiana-build.us.oracle.com/job/install_unit_tests/810/testReport/ >>> >>> >>> 2. Installed nose 1.0.0 on osol-bldsp and install_unit_tests had no >>> new additional failures. The 25 test failures were known problems. >>> >>> http://indiana-build.us.oracle.com/job/install_unit_tests_sparc/31/testReport/ >>> >>> >>> >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> > _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
