I see....thanks for updating. This looks ok now.
ginnie
On 04/12/12 07:24 PM, Mary Ding wrote:
Ginnie:
I had fixed the webrev with both you and Jack's comment:
https://cr.opensolaris.org/action/browse/caiman/md5645/7144255
On 04/12/12 10:19 AM, Virginia Wray wrote:
Hi Mary --
A couple of comments...
usr/src/README -- line 133 - use/uses
Fixed.
usr/src/tools/tests/README -- line 63 looks strange. Why is it so long?
I fixed it and it had line feeds now.
Also, I don't understand point 2 at starting at line 38. If pylint
0.23.0 is being
installed, why do we need the note at line 60?
For S11, the pylint version is 0.18 and it had bugs. Thus we need to
install the latest version of pylint via easy_install to run
slim_code_cleanliness test. Unfortunately, the latest pylint 0.25
does not work with nosexunit at all. As a result, no pylint audit
results will be generated. Based on my testing, only pylint 0.23 will
work and this is why I put the note there to say why we need to
install pylint 0.23.0.
thanks,
ginnie
On 04/11/12 03:00 PM, Mary Ding wrote:
Hi:
Can I get a quick review for the following CR to update
usr/src/README and usr/src/tools/tests/README:
7144255 <http://monaco.us.oracle.com/detail.jsf?cr=7144255> Need to
update usr/src/tools/tests/README and usr/src/README about http
proxy/nosexunit/pylint/nose
The webrev is here:
https://cr.opensolaris.org/action/browse/caiman/md5645/7144255
Testing had been done as follow:
1. I installed nose 1.0.0 on tcu27-01 and install_unit_tests had no
failures:
http://indiana-build.us.oracle.com/job/install_unit_tests/810/testReport/
2. Installed nose 1.0.0 on osol-bldsp and install_unit_tests had no
new additional failures. The 25 test failures were known problems.
http://indiana-build.us.oracle.com/job/install_unit_tests_sparc/31/testReport/
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
