On May 1, 2012, at 6:31 AM, Drew Fisher wrote: > Good morning! > > Could I please get a code review for the following CR: > > 7091644 Using F5 during slice selection often doesn't do anything > > https://cr.opensolaris.org/action/browse/caiman/drewfish/7091644/webrev/ > > There are actually 3 cases where F5 simply doesn't work. > > 1: On a "blank" disk to simply move which slice rpool will occupy > 2: On a disk that has had some limited editing done to it (via format), a > user is not able to move rpool to a presized slice. e.g. if my disk was > carved up with a 50gb s0 and a 50gb s1, TI will start out with s0 marked as > usable by rpool. No matter what the user did, they could never select s1 > 3: Active / Imported pools will not cycle correctly. The cycle pattern ends > up being: Active Pool Name -> Unused -> rpool -> Unused -> rpool .... Using > F5, the user can not ever return back to the Active Pool. This is easily > remedied by pressing F7 to reset the entire screen. > > The fix for this CR addresses cases 1 and 2 above. For case 3, I'm placing > less priority on this issue as the circumstances required to trip over it are > that the user must import a zpool and want to reuse that imported pool's > slice for the rpool zpool. If people feel differently, we can either file a > CR to specifically track that issue.
Sounds reasonable. And +1 -Dave
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
