Thanks Drew...after discussing it in more gory detail,
I understand.
ginnie
On 05/ 3/12 10:08 AM, Drew Fisher wrote:
On 5/3/12 9:34 AM, Virginia Wray wrote:
Hi Drew --
The changes look ok to me.
I have one question...
in partition_edit_screen.py at ln 167, I was wondering
why you didn't use the getattr function with disk.whole_disk?
The Disk class is defined with whole_disk as an attribute so it will
always be there.
use_whole_segment is an attribute that we staple only onto the Disk
object during screen traversal:
# set an attribute on the desired disk so we don't enter the
# partition/slice edit screen.
if isinstance(self.disk, Disk):
self.disk.use_whole_segment = self.use_whole_segment
The fdisk_partitions.py screens are used for both Disks with Slices
and Partitions with Slices. In this case, being x86, the variable of
"self.disk" is not referring to a Disk object, but rather a Partition
object. This is why the use_whole_segment attribute isn't seen later.
Let me know if you have questions and I can try to explain it in more
gory detail.
Thanks for the review!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
