Hi Tomas.
The second and third line of the comment isn't fully accurate. The
first line *is* accurate though as it says "*at least* x permission for
others". (BTW, you can abbreviate that as "o+x".)
The above goes for all places where you've made changes.
Thanks,
Jack
On 05/11/12 06:34 AM, Tomas Dzik wrote:
May I ask one more reviewer to look at fix below ?
Thanks a lot in advance,
Tomas D.
Dne 9.05.12 18:47, Tomas Dzik napsal(a):
Hi all,
I would like to ask you for a code review for:
7161840 AI Sparc client fail to boot when AI service setup with
restrictive umask on S11 FCS
Webrev is here:
https://cr.opensolaris.org/action/browse/caiman/t.dzik/7161840/webrev/
Testing:
1) Sources are pep8 clean
2) I run unittest in gate and the only failed test was:
already logged bug 7043709 which has nothing to do with my fix
3) I reproduced the bug on sparc than built the gate on sparc, and
updated to built version. I run installadm create-service -s
/path/to/iso and verified that client machine is able to install.
Regards,
Tomas D.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
