Hi Jack,
I did that test and it works. It means:
1)
root@lbl-809:~# umask
0077
2)
root@lbl-809:~# installadm list
There are no services configured on this server.
3)
root@lbl-809:/var/ai/service# ls -al
total 9
drwxr-xr-x 3 root sys 3 May 16 08:06 .
drwxr-xr-x 6 root sys 6 Apr 23 13:07 ..
drwxr-xr-x 4 root sys 5 Apr 30 19:39 .conf-templ
4)
installadm create-service -s
/net/nfssys/export/iso/11/ga/sol-11-1111-ai-sparc.iso
5)
root@lbl-809:~# ls -al /var/ai/service/
total 15
drwxr-xr-x 5 root sys 5 May 16 08:30 .
drwxr-xr-x 6 root sys 6 Apr 23 13:07 ..
drwxr-xr-x 4 root sys 5 Apr 30 19:39 .conf-templ
drwx-----x 4 root root 7 May 16 08:30 default-sparc
drwx-----x 4 root root 7 May 16 08:30 solaris11-sparc
6)
root@lbl-809:~# installadm create-manifest -n solaris11-sparc -f
/usr/share/auto_install/manifest/ai_manifest.xml -m my-manifest -c
arch=sun4v
root@lbl-809:~# installadm list -m
Service/Manifest Name Status Criteria
--------------------- ------ --------
default-sparc
orig_default Default None
solaris11-sparc
my-manifest arch = sun4v
orig_default Default None
root@lbl-809:~# installadm list -p
There are no profiles configured for local services.
7)
Then I logged in as regular user (I tried both - su - and login on console)
8)
lbl-809.uk.oracle.com$ installadm list -m
Service/Manifest Name Status Criteria
--------------------- ------ --------
default-sparc
orig_default Default None
solaris11-sparc
my-manifest arch = sun4v
orig_default Default None
9)
lbl-809.uk.oracle.com$ installadm list -p
There are no profiles configured for local services.
So is that what you mean ?
Regards,
Tomas D.
Dne 14.05.12 23:15, Jack Schwartz napsal(a):
Hi Tomas.
Thanks for making the changes.
I thought of one other thing for you to check. I'm wondering if in
service_config.py the mask needs to be 0772. Please test your existing
wad as follows:
1) Set the umask to 0077, then installadm create-service with a name not
already in /var/ai/service/ .
2) Add a manifest to the new service and associate criteria with it (for
example, make it a manifest that works only on arch=sparc)
3) As a normal user, do installadm list -m <service>
If it works, I'm OK with the current changes. If it doesn't, I think
you'll need to change the umask you AND with to 0772.
Thanks,
Jack
On 05/14/12 03:59 AM, Tomas Dzik wrote:
Hi Jack,
thanks for your review. I fixed the comments and the new webrev is here:
https://cr.opensolaris.org/action/browse/caiman/t.dzik/7161840-1/
Is that OK now ?
Regards,
Tomas D.
Dne 11.05.12 23:18, Jack Schwartz napsal(a):
Hi Tomas.
The second and third line of the comment isn't fully accurate. The first
line *is* accurate though as it says "*at least* x permission for
others". (BTW, you can abbreviate that as "o+x".)
The above goes for all places where you've made changes.
Thanks,
Jack
On 05/11/12 06:34 AM, Tomas Dzik wrote:
May I ask one more reviewer to look at fix below ?
Thanks a lot in advance,
Tomas D.
Dne 9.05.12 18:47, Tomas Dzik napsal(a):
Hi all,
I would like to ask you for a code review for:
7161840 AI Sparc client fail to boot when AI service setup with
restrictive umask on S11 FCS
Webrev is here:
https://cr.opensolaris.org/action/browse/caiman/t.dzik/7161840/webrev/
Testing:
1) Sources are pep8 clean
2) I run unittest in gate and the only failed test was:
already logged bug 7043709 which has nothing to do with my fix
3) I reproduced the bug on sparc than built the gate on sparc, and
updated to built version. I run installadm create-service -s
/path/to/iso and verified that client machine is able to install.
Regards,
Tomas D.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
