Hi Mary --
Looks good.
ginnie
On 05/22/12 04:09 PM, Mary Ding wrote:
Hi:
Can I get a code review for the following bug fix for
usr/src/cmd/system-config/support.py
CR: http://monaco.sfbay/detail.jsf?cr=7170341 several labels of
text-install/sysconfig support screens are not localizable
Web rev is here and is suggested by Takeshi-san:
https://cr.opensolaris.org/action/browse/caiman/md5645/7170341
Testing is done this way:
1. Ran slim_install_unit tests for both sparc and x86. There were no
regression.
x86 results pointer:
/net/tcu27-01/export/home/ding/7170341/slim_source/usr/src/tools/tests/test_result
sparc results pointer:
/net/osol-bldsp/datapool/ding/7170341/slim_source/usr/src/tools/tests/test_result
2. Ran pep8 and pylint and there were no issues.
3. I use DC to build TI images for sparc and x86.
x86 - TI installs works
sparc - TI installs works
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
