Hi Jack,
On 2012年05月24日 05:39, Jack Schwartz wrote:
HI Mary and Takeshi-san.
The OCM_HUB_LABEL line is the only one with spaces in it.
I'm thinking something like the following for OCM_HUB_LABEL is best:
OCM_HUB_LABEL = " " + _("OCM Hub URL:")
This way, the spaces stay out of the way, and the text can still be translated.
IMO it is better to translate and have the spacing be off, than to not do any
translation at all by removing the _().
Thank you for evaluation.
If the spaces are for indentation, the way is sufficient and
reasonable.
But it seems to me that the spaces in this case are for padding
purpose to align the two labels. i.e. number of spaces should
be adjusted depending on result of _().
I only briefly looked at the code, not in depth. So if I have
misunderstanding could you please excuse me and correct.
Eliminate static padding from OCM_HUB_LABEL, change
the code to compare #columns needed for the labels, and
adding space(s) for padding to the one needs lesser #columns,
would work well with translations.
It may be clearer if I can explain with sample diff or webrev
but I afraid I may not be able to have time for that today or
tomorrow.
From localization's point of view, the bug (the forked 7171004)
does not need fix in b17. Fixing it in b18 is fine.
Thanks,
Takeshi
My $.02,
Jack
On 05/22/12 06:55 PM, Takeshi Asano wrote:
Hi Mary,
On 2012年05月23日 09:55, Mary Ding wrote:
Takeshi-san:
I will file a seperate CR to address the sizing of area for label of the two
areas together. This is something that I am no familiar with and had no idea
how to fix it approriately.
For the time being,is it OK to do _() for OCM and ASR as well, otherwise, I
will just remove _() if it is OK with you.
Either is ok but if it's easy to remove _() from the two labels
could you please do so, so no it's not needed to have tentative
care by translators to keep width of the two labels manually.
Thanks,
Takeshi
On 05/22/12 05:48 PM, Takeshi Asano wrote:
Hi Karen and Mary,
Karen's point is valid and it's more appropriate
internationalization to eliminate padding spaces from
the static string and doing dynamic padding.
But currently it seems that sizing of area for label
" OCM Hub URL:" and that for "ASR Manager URL:" are
being done separately.
So the fix would need sizing of the two areas together.
If the fix can be done within this CR, it'll be great.
If not possible, addressing it in separate CR is also ok.
Thanks,
Takeshi
On 2012年05月23日 08:56, Mary Ding wrote:
Karen:
I will ask Takeshi-san about this and get back to you.
On 05/22/12 04:51 PM, Karen Tung wrote:
Hi Mary,
I have a question for line 981.
In the original strings, there are multiple empty spaces preceding "OCM Hub
URL".
I assume those are used for lining up with the string defined in
ASR_HUB_LABEL. I see that those spaces
are also included inside the _(). Do you know whether that's OK? I am wondering
whether
the spacing will get messed up if the spaces are included, and the translated
string of "OCM Hub URL" is longer...
Thanks,
--Karen
On 05/22/12 15:09, Mary Ding wrote:
Hi:
Can I get a code review for the following bug fix for
usr/src/cmd/system-config/support.py
CR: http://monaco.sfbay/detail.jsf?cr=7170341 several labels of
text-install/sysconfig support screens are not localizable
Web rev is here and is suggested by Takeshi-san:
https://cr.opensolaris.org/action/browse/caiman/md5645/7170341
Testing is done this way:
1. Ran slim_install_unit tests for both sparc and x86. There were no regression.
x86 results pointer:
/net/tcu27-01/export/home/ding/7170341/slim_source/usr/src/tools/tests/test_result
sparc results pointer:
/net/osol-bldsp/datapool/ding/7170341/slim_source/usr/src/tools/tests/test_result
2. Ran pep8 and pylint and there were no issues.
3. I use DC to build TI images for sparc and x86.
x86 - TI installs works
sparc - TI installs works
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
