Good morning!
Could I please get a few sets of eyes on a code review for the following
CRs:
7171070 <http://monaco.us.oracle.com/detail.jsf?cr=7171070> text-install
should update the error messages for invalid slice size
7173030 <http://monaco.us.oracle.com/detail.jsf?cr=7173030> text-install
Installation Failed because of "/usr/sbin/swap -d /dev/dsk/c8t0d0swap"
failed
https://cr.opensolaris.org/action/browse/caiman/drewfish/ti_fixes/webrev/
The fix for 7171070 is to simply return the quote characters around the
radix character in the error message.
The fix for 7173030 is a small refactor of Disk._release_swap(). The
code there was designed a long time ago for the temporary version of
target instantiation needed for DC before CUD_TI was completed. It was
designed for releasing swap on zpool, which was the reason for adding
the string of "swap" to the end of the swap -d call. Since we're in the
Disk class, there's no knowledge of anything ZFS which means we can
simply use the CTD string of the disk for comparison.
I tested 7173030 by creating a UFS swap slice on the disk I was
attempting to install to and verifying swap -d is called correctly
before zpool create gets called.
Thanks!
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
