Hi Drew,
On 05/31/12 09:46, Drew Fisher wrote:
Karen,
On 5/31/12 10:16 AM, Karen Tung wrote:
Hi Drew,
In physical.py, the function you updated is called _release_swap().
Since that function
is only releasing UFS swap slices, I think it would be better to
rename it to
_release_ufs_swap(). This change also better matches with the name of
the following function: "_create_ufs_swap()". Can you also update
the comment
to explicitly say that the function only takes care of swap slices on
disks?
Yep:
def _release_ufs_swap(self):
""" method to release all UFS swap devices associated on this disk
"""
Does that look ok to you?
Yes, this looks good to me.
On testing, did you run the slim unit tests?
No, because we have no tests for target instantiation or textui error
message checking. I did just run the target unittests and have no errors:
[leeroy:src] > cd lib/install_target/
[leeroy:install_target] > cd test/
[leeroy:test] > sudo nosetests -sx test_*.py
............................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 268 tests in 131.785s
OK
These are the only moving components of this wad, so I'm not sure what
additional testing (if any) you'd like to see.
I was just wondering about the slim unit tests for target. Looks like
you just run them,
and there are no errors.
I have no further comments.
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
