Good morning!
Could I please get a code review for the following CRs:
7166975 <http://monaco.us.oracle.com/detail.jsf?cr=7166975> AI install
failed with [Errno 5] I/O error on T5220 with internal RAID (AAC) boot disk
7173754 <http://monaco.us.oracle.com/detail.jsf?cr=7173754> AI install
failed with IndexError: list index out of range if there is passive
disks present
https://cr.opensolaris.org/action/browse/caiman/drewfish/7166975/webrev/
Since we're in target discovery, there's no unittests. I had the bug
submitter verify both fixes on his two systems, however.
The large line delta in the webrev is misleading due to a massive
de-dent in the code going from line 266-342. I also changed an error
message to use a better variable name. Moving from new_disk.name (which
is always "disk" - line 160) to drive.name (which is the drive's devid)
should help with logging in the future.
-Drew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
