Jan and Karen: FYI. The current slim unit tests had 97 failures and all of them are related to missing default log files. Ginnie already filed a bug for that. ----- Original Message ----- From: [email protected] To: [email protected] Cc: [email protected] Sent: Wednesday, June 20, 2012 9:36:41 AM GMT -08:00 US/Canada Pacific Subject: Re: [caiman-discuss] CR request for 7178279
Hi Jan, Your changes look good to me. You didn't mention below, did you also run the slim unit tests to make sure there's no regression? Thanks, --Karen On 06/20/12 03:40 AM, Jan Damborsky wrote: > Hi Sue, Karen, > > thank you for catching that issue and for evaluating its root cause. > > Since you are familiar with the problem, could I please ask you > to review fix for that bug ? > > webrev: > https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7178279/webrev-1/ > > > Thank you very much, > Jan > > > testing done: > * build AI, text, LiveCD media from latest slim_source bits, > nightly IPS repo and stock b18 bits > > * so far tested interactive installations (with login jack > for to-be-created user account): > - text installer booted from network > - text installer booted from media > - GUI installer > > - AI testing in progress (should not be affected by this change) > > * verified that > - 'jack' entry is no longer present in shadow(4) on installed system > - it is possible to log in to installed system as 'jack' user > - changes are pep8 clean > - there are no new errors from pylint > _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
