Thank you for review, Karen.
Yep, I ran install_ict unit tests:
# ./slim_test lib/install_ict/
...
Ran 23 tests in 0.157s
OK
#
Jan
On 06/20/12 18:35, Karen Tung wrote:
Hi Jan,
Your changes look good to me.
You didn't mention below, did you also run the slim unit tests to make
sure
there's no regression?
Thanks,
--Karen
On 06/20/12 03:40 AM, Jan Damborsky wrote:
Hi Sue, Karen,
thank you for catching that issue and for evaluating its root cause.
Since you are familiar with the problem, could I please ask you
to review fix for that bug ?
webrev:
https://cr.opensolaris.org/action/browse/caiman/dambi/cr-7178279/webrev-1/
Thank you very much,
Jan
testing done:
* build AI, text, LiveCD media from latest slim_source bits,
nightly IPS repo and stock b18 bits
* so far tested interactive installations (with login jack
for to-be-created user account):
- text installer booted from network
- text installer booted from media
- GUI installer
- AI testing in progress (should not be affected by this change)
* verified that
- 'jack' entry is no longer present in shadow(4) on installed system
- it is possible to log in to installed system as 'jack' user
- changes are pep8 clean
- there are no new errors from pylint
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
