Thanks Dermot!
On 03/07/2012 17:40, Dermot McCluskey wrote:
Niall,
LGTM and thanks for fixing this.
- Dermot
On 07/03/12 16:34, Niall Power wrote:
Good morning!
Can I ask for a couple of reviewers for the following bug:
http://monaco.us.oracle.com/detail.jsf?cr=7163453
The real problem, responsible for this bug, is that localisation for
pygtk and glade is not properly initialised and hence the rather
large hack that is translate_labels() in screen-manager.py
The solution is to properly initialise glade's textdomain so that the
hack can be removed. Note that the time combo box (AM / PM / 24 hour)
internationalisation is a bit odd and so it gets some special setup
in translate_labels(). To faciliate removal of translate_labels() and
because it better belongs with the rest of the timezone.py code, I
have moved it there.
John:
Dermot tells me you wrote translate_labels() so if there is any other
special condition that I am not aware of let me know. Everything
appears to be working for me.
I have tested the results under French, German, Japanese and
Simplified Chinese locales and labels are displaying correctly
localised.
Pep8/pylint clean.
Webrev:
http://jurassic.us.oracle.com/~npower/webrevs/webrev-7163453
Thanks,
Niall
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
