LGTM, Jack
-Drew
On 7/16/12 4:03 PM, Jack Schwartz wrote:
Hi everyone.
Here is a really simple fix for bug ID:
7183989 "No proxy"/"Proxy"/"Aggregation Hubs" take 2
https://cr.opensolaris.org/action/browse/caiman/schwartz/7183989_1/webrev/
Please review ASAP.
The issue is misalignment that arises when displaying a localized menu.
The fix calls a different function to do the alignment. The fix was
provided by Takeshi Asano of the L10N team.
While this is not a stopper, it is an L10N messaging fix and so can
still go into B21.
Testing done:
Verified that English displays properly.
Pep8 and pylint.
AI and TI images built.
Testing pending:
Verify that Japanese or another language displays properly.
(To be done by Takeshi Asano.)
I'll push tomorrow AM pending code review approval and successful testing.
Thanks,
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
