Hi Takeshi-san. On 07/16/12 18:55, Takeshi Asano wrote:
Hi Jack,On 2012年07月17日 07:03, Jack Schwartz wrote:Hi everyone. Here is a really simple fix for bug ID: 7183989 "No proxy"/"Proxy"/"Aggregation Hubs" take 2https://cr.opensolaris.org/action/browse/caiman/schwartz/7183989_1/webrev/Please review ASAP. The issue is misalignment that arises when displaying a localized menu.The fix calls a different function to do the alignment. The fix was provided by Takeshi Asano of the L10N team.While this is not a stopper, it is an L10N messaging fix and so can still go into B21.Testing done: Verified that English displays properly. Pep8 and pylint. AI and TI images built. Testing pending: Verify that Japanese or another language displays properly. (To be done by Takeshi Asano.)Testing done successfully.
Great! Thanks for doing that.
The period is a nit, but I think the menu looks sloppy when one item has it and the others do not, so I'd like to leave it removed. However, if my removal of the period makes you miss your bugfix deadline, I'll put it back and file a P4 bug for update 2.But the changeset looks not only does the logic change but also removes periodfrom description for the No Proxy. Then that string will be displayed in English. If the removal of preriod is not so important, please resume the period. If it's important, I'll consider syncing up localization in b22.
Please let me know.
Thanks again,
Jack
Thanks, TakeshiI'll push tomorrow AM pending code review approval and successful testing.Thanks, Jack _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
