Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> writes: > Hi Everyone, > > I’ve been working on act_ctinfo toward getting that upstream and it is > getting closer. Since that module along with act_connmark does its own > conntrack lookups I’ve been looking at what they do and what we do in > cake. > > Two patches attached - one is a simple variable elimination with no > functional change. The second changes/simplifies the conntrack tuple > lookup & usage. I’ve had a play and I don’t think I’ve broken any of > the host fairness BUT it could do with some more testing, that’s where > you come in… probably Pete & George :-)
Seems reasonable. But please fold these two patches into one; changing everything, then immediately changing it again does not help readability... And the explanation makes a lot more sense if you just change the whole thing in one patch :) -Toke _______________________________________________ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/cake
