> On 3 May 2019, at 15:16, Jonathan Morton <chromati...@gmail.com> wrote: > >> On 3 May, 2019, at 4:55 pm, Kevin Darbyshire-Bryant >> <ke...@darbyshire-bryant.me.uk> wrote: >> >> Two patches attached - one is a simple variable elimination with no >> functional change. The second changes/simplifies the conntrack tuple lookup >> & usage. I’ve had a play and I don’t think I’ve broken any of the host >> fairness BUT it could do with some more testing, that’s where you come in… > > Looks like sound logic, as long as it does actually work. It could be a > useful speedup for those small CPE devices which need NAT and host-fairness > working.
It’s interesting you bring that up - are we sure that ingress host NAT fairness works in the upstream kernel version of CAKE anyway? I’m looking at cake_update_flowkeys(…) and thinking half of it is missing? > > - Jonathan Morton Cheers, Kevin D-B gpg: 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A _______________________________________________ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/cake