interestingly this would be an example, I think, of a plugin that has no js call ... and it inits before anything else
or am I missing something? On Tue, Apr 24, 2012 at 12:42 PM, Filip Maj <f...@adobe.com> wrote: > I'd like to first hear what everyone else on the list thinks :) > > On 4/24/12 12:37 PM, "Joe Bowser" <bows...@gmail.com> wrote: > >>Sounds good! Let's create some tickets in JIRA and hash this out. >> >>On Tue, Apr 24, 2012 at 10:16 AM, Filip Maj <f...@adobe.com> wrote: >> >>> I am in HUGE favor of creating a Splash Screen plugin (iOS does this >>> already, it looks like Simon is going down that path) that we make work >>> consistently across platforms. >>> >>> Would be a good exercise in plugin authoring, something that we need to >>> work out details for for 2.0 anyways (but that's a separate thread). >>> >>> Finally: the JS for the Splash Screen plugin would be dead simple. At >>>its >>> simplest: >>> >>> cordova.onDeviceReady.subscribeOnce(function() { exec(function(){}, >>> function(){}, 'splashscreen', 'hide', []); }); >>> >>> Or, more complex, we could expose as a core cordova API and offer APIs >>>for >>> showing and hiding. >>> >>> On 4/24/12 9:37 AM, "Joe Bowser" <bows...@gmail.com> wrote: >>> >>> >OK, here's where I go against what I've been saying for years about >>> >Spashscreens being a stupid exercise in branding and come out in >>>defence >>> >of >>> >this approach. That being said, does it have to be a dialog, or can >>>we do >>> >something tricky with an ImageView in the background. I agree that our >>> >splashscreen is janky, and needs to be fixed, but we should make it so >>> >that >>> >you can't tell it's a Cordova app. >>> > >>> >But yeah, I'm fine with this code being put into the CordovaWebView >>>branch >>> >and tickets being added to get it here. >>> > >>> >On Tue, Apr 24, 2012 at 9:23 AM, Brian LeRoux <b...@brian.io> wrote: >>> > >>> >> Woah, hold up: >>> >> >>> >> "The only downside is the dialog does not fully cover the screen." >>> >> >>> >> Not in a spot to test this yet but how much is covered / how big is >>> >> the visual change? >>> >> >>> >> If its at all different would we not want to deprecate the old >>> >> functionality and warn of the new behavior? >>> >> >>> >> Final thought, perhaps we could consider axing splash screens >>> >> altogether. It kinda should be handled by the client code and not the >>> >> native side, imo. >>> >> >>> >> >>> >> On Tue, Apr 24, 2012 at 8:21 AM, Joe Bowser <bows...@gmail.com> >>>wrote: >>> >> > On Tue, Apr 24, 2012 at 7:40 AM, Simon MacDonald >>> >> > <simon.macdon...@gmail.com>wrote: >>> >> > >>> >> >> Hey, >>> >> >> >>> >> >> I did a bit of a refactor on the Android splash screen. I didn't >>>like >>> >> the >>> >> >> fact that when you do a: >>> >> >> >>> >> >> *super*.setIntegerProperty("splashscreen", R.drawable.*splash)*; >>> >> >> >>> >> >> *super*.loadUrl("file:///android_asset/www/conn.html", 5000); >>> >> >> The splash screen is shown for 5 seconds then the web view begins >>>to >>> >> load >>> >> >> the page. That is, the splash screen is a blocking call. >>> >> >> >>> >> >> I believe I've made this better by changing the way we display the >>> >> splash >>> >> >> screen to a dialog box. This way the web view underneath the >>>dialog >>> >>can >>> >> >> continue to load the web page while splash screen is being >>>displayed. >>> >> >> Additionally, I've added a splash screen plugin to Android so you >>>can >>> >> call >>> >> >> it's hide method to make the splash screen go away in your >>> >>onDeviceReady >>> >> >> handler. For developers using our API I haven't changed the way >>>the >>> >> splash >>> >> >> screen is setup so they won't be required to change their code. >>>The >>> >>only >>> >> >> downside is the dialog does not fully cover the screen. >>> >> >> >>> >> >> Here is the commit: >>> >> >> >>> >> >> >>> >> >> >>> >> >>> >> >>> >>>https://github.com/macdonst/cordova-android/commit/d359eaf4534dc0eed91cda >>> >>c7e9e0bd23ab36bc46 >>> >> >> >>> >> >> Comments? Is this something I should push into the Android repo >>>for >>> >>1.8? >>> >> >> Can we hook something in the common JS so folks can call hide on >>>the >>> >> splash >>> >> >> screen plugin on Android and iOS? >>> >> >> >>> >> >> >>> >> > Looks good, and it solves a problem that we've been having with the >>> >>way >>> >> we >>> >> > do splashscreens. We may need to add exception handling for the >>> >>plugin >>> >> if >>> >> > people do something stupid like use it with a CordovaWebView, but >>> >>other >>> >> > than that it looks good and is much easier to read than the current >>> >>code. >>> >> > Please push this into the Android repo for 1.8. Let me know if >>> >>there's >>> >> > problems merging it with the CordovaWebView branch. >>> >> > >>> >> > Joe >>> >> >>> >>> >