On Fri, Apr 09, 2010 at 09:05:46AM +0100, Mike Jagdis wrote:
> On Thu, Apr 08, 2010 at 08:06:56PM +0300, Tzafrir Cohen wrote:
> > On Thu, Apr 08, 2010 at 05:36:19PM +0100, Mike Jagdis wrote:
> > > Absolutely. What is the library?
> >
> > Vale. Is it still required?
>
> Yes. It comes from the same place spandsp does
> (http://www.soft-switch.org/)
Where do you report bugs for it?
--
Tzafrir Cohen
icq#16849755 jabber:[email protected]
+972-50-7952406 mailto:[email protected]
http://www.xorcom.com iax:[email protected]/tzafrir
>From 7fa35c46974d69fb977f1e0852e786d6439a4126 Mon Sep 17 00:00:00 2001
From: Tzafrir Cohen <[email protected]>
Date: Sat, 10 Apr 2010 05:52:53 +0300
Subject: [PATCH 1/3] make rfc3550.c build with laters compilers
* Remove AC_C_CONST that caused problems if we actually tried to use const.
* Remove similar obsolete AC_C_VOLATILE and AC_C_INLINE.
* gcc had some issues with "'"-s that were in a '#if 0' code section.
* Remove (#if 0) two unused static functions.
---
configure.ac | 4 ----
src/rfc3550.c | 8 +++++---
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/configure.ac b/configure.ac
index 468c236..fda8c76 100644
--- a/configure.ac
+++ b/configure.ac
@@ -114,10 +114,6 @@ else
CXXFLAGS=${CXXFLAGS-"-g -O2"}
fi
-AC_C_CONST
-AC_C_INLINE
-AC_C_VOLATILE
-
AC_CHECK_TYPES(long long)
AC_CHECK_TYPES(long double)
diff --git a/src/rfc3550.c b/src/rfc3550.c
index 0149740..bd2b979 100644
--- a/src/rfc3550.c
+++ b/src/rfc3550.c
@@ -292,7 +292,7 @@ struct rfc3550_policy_s
the one saved in the table entry for this identifier)
{
/* An identifier collision or a loop is indicated */
- if (source identifier is not the participant's own)
+ if ("source identifier is not the participant's own")
{
/* OPTIONAL error counter step */
if (source identifier is from an RTCP SDES chunk
@@ -315,7 +315,7 @@ struct rfc3550_policy_s
/* OPTIONAL error counter step */
if (source identifier is not from an RTCP SDES chunk containing a CNAME item
||
- CNAME is the participant's own)
+ "CNAME is the participant's own")
{
count occurrence of own traffic looped;
}
@@ -992,6 +992,7 @@ uint32_t rfc3550_get_ssrc(rfc3550_state_t *s)
}
/*- End of function --------------------------------------------------------*/
+#if 0
static void init_seq(rfc3550_source_info_t *s, uint16_t seq)
{
s->base_seq = seq;
@@ -1072,6 +1073,7 @@ static int update_seq(rfc3550_source_info_t *s, uint16_t seq)
s->received++;
return 0;
}
+#endif
/*- End of function --------------------------------------------------------*/
int rfc3550_rx_rtp_packet(rfc3550_state_t *s, const uint8_t buf[], int len)
@@ -1422,7 +1424,7 @@ static void rx_rtcp_app(rfc3550_state_t *s, const uint8_t buf[], int len)
ptr += 1*sizeof(uint32_t);
memcpy(name, ptr, 4);
name[4] = '\0';
- printf("APP name '%s' - %d bytes of data\n", name, (len - 3)*sizeof(uint32_t));
+ printf("APP name '%s' - %zd bytes of data\n", name, (len - 3)*sizeof(uint32_t));
}
/*- End of function --------------------------------------------------------*/
--
1.7.0
>From f32015afcb2c48ca203f8fb22715fa1a7d399753 Mon Sep 17 00:00:00 2001
From: Tzafrir Cohen <[email protected]>
Date: Sat, 10 Apr 2010 05:56:31 +0300
Subject: [PATCH 2/3] Bump the version to 0.0.2
---
configure.ac | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index fda8c76..2709653 100644
--- a/configure.ac
+++ b/configure.ac
@@ -40,7 +40,7 @@ AC_CACHE_CHECK([for _AC_LANG compiler vendor], ax_cv_[]_AC_LANG_ABBREV[]_compile
VALE_MAJOR_VERSION=0
VALE_MINOR_VERSION=0
-VALE_MICRO_VERSION=1
+VALE_MICRO_VERSION=2
VALE_LT_CURRENT=0
VALE_LT_REVISION=1
--
1.7.0
>From 9e7643c9f1dcf2ef4182411d4d64c57a50ccbea1 Mon Sep 17 00:00:00 2001
From: Tzafrir Cohen <[email protected]>
Date: Sat, 10 Apr 2010 05:58:24 +0300
Subject: [PATCH 3/3] Fix src/Makefile.am to pass distcheck
* Remove the generated vale/version.h on 'make dist-clean'.
* Generate it in the right place.
---
src/Makefile.am | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 0ad88d4..fd3dbcf 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -20,7 +20,7 @@
AM_CFLAGS = $(COMP_VENDOR_CFLAGS)
-MAINTAINERCLEANFILES = Makefile.in
+DISTCLEANFILES = vale/version.h
INCLUDES = -I$(top_builddir)
@@ -102,10 +102,11 @@ vale/version.h:
NOWDATE=`date --utc +"%Y%m%d"` ; \
NOWTIME=`date --utc +"%H%M%S"` ; \
sed 's/$$VALE_RELEASE_DATE/'$$NOWDATE'/;s/$$VALE_RELEASE_TIME/'$$NOWTIME'/' \
- <vale/version.h.in >vale/version.h
+ <$(srcdir)/vale/version.h.in >$@
dist-hook:
NOWDATE=`date --utc +"%Y%m%d"` ; \
NOWTIME=`date --utc +"%H%M%S"` ; \
+ chmod u+w $(distdir)/vale/version.h; \
sed 's/$$VALE_RELEASE_DATE/'$$NOWDATE'/;s/$$VALE_RELEASE_TIME/'$$NOWTIME'/' \
- <vale/version.h.in >vale/version.h
+ <$(srcdir)/vale/version.h.in >$(distdir)/vale/version.h
--
1.7.0
_______________________________________________
Callweaver-dev mailing list
[email protected]
http://lists.callweaver.org/mailman/listinfo/callweaver-dev