Created an issue & assigned to Janaka - https://wso2.org/jira/browse/CARBON-12299 /sumedha
On Sun, Jan 29, 2012 at 9:43 PM, Sanjiva Weerawarana <sanj...@wso2.com>wrote: > No ack .. Azeez maybe you should create an issue .. that way it doesn't > get lost! > > On Thu, Jan 26, 2012 at 5:38 PM, Afkham Azeez <az...@wso2.com> wrote: > >> This class in in really bad shape. It has about 20 maps each correspond >> to a method, and in the addHandler methods check for the method doing a >> String comparison & add to the relevant map! Really bad OO design. I guess >> introducing another class which has the Map & method will greatly reduce >> the LOC in this class. >> >> >> On Thu, Jan 26, 2012 at 5:31 PM, Afkham Azeez <az...@wso2.com> wrote: >> >>> See attached screenshot. This type of code should be properly refactored >>> to use enums. >>> >>> -- >>> *Afkham Azeez* >>> Director of Architecture; WSO2, Inc.; http://wso2.com >>> Member; Apache Software Foundation; http://www.apache.org/ >>> * <http://www.apache.org/>** >>> email: **az...@wso2.com* <az...@wso2.com>* cell: +94 77 3320919 >>> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >>> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >>> * >>> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >>> * >>> * >>> *Lean . Enterprise . Middleware* >>> >>> >> >> >> -- >> *Afkham Azeez* >> Director of Architecture; WSO2, Inc.; http://wso2.com >> Member; Apache Software Foundation; http://www.apache.org/ >> * <http://www.apache.org/>** >> email: **az...@wso2.com* <az...@wso2.com>* cell: +94 77 3320919 >> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >> * >> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >> * >> * >> *Lean . Enterprise . Middleware* >> >> >> _______________________________________________ >> Carbon-dev mailing list >> Carbon-dev@wso2.org >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> > > > -- > Sanjiva Weerawarana, Ph.D. > Founder, Chairman & CEO; WSO2, Inc.; http://wso2.com/ > email: sanj...@wso2.com; phone: +94 11 763 9614; cell: +94 77 787 6880 | +1 > 650 265 8311 > blog: http://sanjiva.weerawarana.org/ > > > Lean . Enterprise . Middleware > > _______________________________________________ > Carbon-dev mailing list > Carbon-dev@wso2.org > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > > -- /sumedha +94 773017743
_______________________________________________ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
