Hi all,

+1 for using Enumerations in here. I've also pointed out potential issues
and related areas we can further improve when this gets properly fixed.

Thanks,
Senaka.

On Mon, Jan 30, 2012 at 8:53 AM, Afkham Azeez <[email protected]> wrote:

> When these type of mails are sent we expect an acknowledgement & show of
> ownership by the primary team, and now by the *PMC*
>
> --
> Afkham Azeez
> Sent from my phone
> On Jan 29, 2012 9:43 PM, "Sanjiva Weerawarana" <[email protected]> wrote:
>
>> No ack .. Azeez maybe you should create an issue .. that way it doesn't
>> get lost!
>>
>> On Thu, Jan 26, 2012 at 5:38 PM, Afkham Azeez <[email protected]> wrote:
>>
>>> This class in in really bad shape. It has about 20 maps each correspond
>>> to a method, and in the addHandler methods check for the method doing a
>>> String comparison & add to the relevant map! Really bad OO design. I guess
>>> introducing another class which has the Map & method will greatly reduce
>>> the LOC in this class.
>>>
>>>
>>> On Thu, Jan 26, 2012 at 5:31 PM, Afkham Azeez <[email protected]> wrote:
>>>
>>>> See attached screenshot. This type of code should be properly
>>>> refactored to use enums.
>>>>
>>>> --
>>>> *Afkham Azeez*
>>>> Director of Architecture; WSO2, Inc.; http://wso2.com
>>>> Member; Apache Software Foundation; http://www.apache.org/
>>>> * <http://www.apache.org/>**
>>>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919
>>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>*
>>>> twitter: 
>>>> **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
>>>> *
>>>> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
>>>> *
>>>> *
>>>> *Lean . Enterprise . Middleware*
>>>>
>>>>
>>>
>>>
>>> --
>>> *Afkham Azeez*
>>> Director of Architecture; WSO2, Inc.; http://wso2.com
>>> Member; Apache Software Foundation; http://www.apache.org/
>>> * <http://www.apache.org/>**
>>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919
>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>*
>>> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
>>> *
>>> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
>>> *
>>> *
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> _______________________________________________
>>> Carbon-dev mailing list
>>> [email protected]
>>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>
>>>
>>
>>
>> --
>> Sanjiva Weerawarana, Ph.D.
>> Founder, Chairman & CEO; WSO2, Inc.;  http://wso2.com/
>> email: [email protected]; phone: +94 11 763 9614; cell: +94 77 787 6880 | +1
>> 650 265 8311
>> blog: http://sanjiva.weerawarana.org/
>>
>> Lean . Enterprise . Middleware
>>
>> _______________________________________________
>> Carbon-dev mailing list
>> [email protected]
>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>
>>
> _______________________________________________
> Carbon-dev mailing list
> [email protected]
> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>


-- 
*Senaka Fernando*
Product Manager - WSO2 Governance Registry;
Associate Technical Lead; WSO2 Inc.; http://wso2.com*
Member; Apache Software Foundation; http://apache.org

E-mail: senaka AT wso2.com
**P: +1 408 754 7388; ext: 51736*; *M: +94 77 322 1818
Linked-In: http://linkedin.com/in/senakafernando

*Lean . Enterprise . Middleware
_______________________________________________
Carbon-dev mailing list
[email protected]
http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Reply via email to