On Tue, Feb 14, 2012 at 3:42 PM, Prabath Siriwardena <prab...@wso2.com> wrote: > > > On Tue, Feb 14, 2012 at 3:31 PM, Afkham Azeez <az...@wso2.com> wrote: >> >> >> >> On Tue, Feb 14, 2012 at 3:22 PM, Amila Jayasekara <ami...@wso2.com> wrote: >>> >>> Hi All, >>> >>> We had a review discussion on Carbon Authenticators and following are >>> the review notes. >>> >>> 1. There are some common logic that should be implemented in every >>> authenticator. Currently invoking this logic is duplicated among >>> authenticators. So to avoid that we are planning to come up with an >>> abstract Authenticator implementation. >>> 2. As per now AuthenticationHandler first invokes AuthenticationAdmin >>> and then it calls chain of authenticators. The AuthenticationAdmin >>> call is not necessary. We need to refactor code in such a way that >>> authenticator it self will only handle authenticating logic (Rather >>> than within the Handler). >>> 3. Properly implement authenticator chaining pattern. Make use >>> “isHandle” >> >> >> Shouldn't this be isHandled? > > > Yes.. we discussed today to change the name.. and suggestion was to rename > it to canHandle()..
Yes, names which i mentioned are not precise. Just wanted to give a high level idea of the process. Will name appropriately and after changes we can do a code review. Thanks AmilaJ > > Thanks & regards, > -Prabath > >> >> >>> >>> , “priority”, “isAuthenticated” methods and make only >>> authenticator aware about the logic. >>> 4. After cleaning up the API, implement “Basic Auth” authenticator. >>> (As first step) >>> >>> Thanks >>> AmilaJ >>> >>> -- >>> Mobile : +94773330538 >>> _______________________________________________ >>> Carbon-dev mailing list >>> Carbon-dev@wso2.org >>> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> >> >> >> >> -- >> Afkham Azeez >> Director of Architecture; WSO2, Inc.; http://wso2.com >> Member; Apache Software Foundation; http://www.apache.org/ >> >> email: az...@wso2.com cell: +94 77 3320919 >> blog: http://blog.afkham.org >> twitter: http://twitter.com/afkham_azeez >> linked-in: http://lk.linkedin.com/in/afkhamazeez >> >> Lean . Enterprise . Middleware >> >> >> _______________________________________________ >> Carbon-dev mailing list >> Carbon-dev@wso2.org >> http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev >> > > > > -- > Thanks & Regards, > Prabath > > Mobile : +94 71 809 6732 > > http://blog.facilelogin.com > http://RampartFAQ.com > > > _______________________________________________ > Carbon-dev mailing list > Carbon-dev@wso2.org > http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev > -- Mobile : +94773330538 _______________________________________________ Carbon-dev mailing list Carbon-dev@wso2.org http://mail.wso2.org/cgi-bin/mailman/listinfo/carbon-dev
