> 1. A vision, goals, spec like doc should be produced in the spirit of > those done for LOA and LPPE. This doc should help other committers > and contributors understand what is being changed and why, what impact > it has, and how it relates to and enables LOA, MFA, and other goals.
I have provided a clear description of changes. I'm perfectly willing to expand upon the changes and clarify how they integrate with other efforts. > This document should list the public published CAS3 APIs that are > being changed. Sounds reasonable. > 2. All changes unrelated to CAS-1238 should be removed from the change > set to facilitate understanding and review. It's not at all clear how to accomplish this. > 3. Where possible break the change set into a number of smaller pull > requests that can be reviewed in stages. In practice this is simply a restatement of #2. > 4. Given this is a substantial change, it should be brought to > completion on a feature-branch before merging to master. It's already on a feature branch in my public repository: https://github.com/serac/cas/tree/cas-1238 It seems to me like a bookkeeping matter where that repository lives, but I could push it up to the Jasig repo if it matters. I don't see how to move past these obstacles. You are effectively asking for herculean refactoring of the patches on top of a substantial amount of development and testing. You'll have to offer something more than a qualified word of support to indicate that any further effort will be worthwhile. M -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
