I too favor a Jasig/cas topic branch with commits/pull requests with commit messages better articulating the changes for easier understanding. Thanks for being open to doing that, Marvin.
More importantly as I see it, a topic branch will also allow working beyond the scope of the existing pull request to continue to collaborate on making use of, further improving the new APIs. I'm eager to better understand how the new APIs can be exercised in the service of use cases of requiring stronger authentication depending on service registration metadata, participation in an enhanced CAS protocol, or even risk-based adaptive behaviors in the CAS server. A topic branch should be a good place to explore that. On Tue, Jan 29, 2013 at 11:04 AM, William G. Thompson, Jr. <[email protected] > wrote: > On Mon, Jan 28, 2013 at 9:56 AM, Marvin Addison > <[email protected]> wrote: > >> I wish we can get out of this "deadlock". > > > > +1 > +1 > > > > >> it would have been necessary to have more documentation and small pull > requests instead of a big one. > > > > This is a fair criticism. In retrospect, I wish I had approached the > > work more conservatively. > > > >> For major evolution, we should always write spec with several work > items, present it to the community and then deliver pull requests for every > listed step. > > > > I respectfully disagree. There are many potential ways to approach > > change. I took the approach of developing a complete, working solution > > and presented it for discussion. I had envisioned refactoring and > > documentation to come as a natural consequence of the subsequent > > discussion. I took this approach in large part because I wanted to > > produce something instead of spending undue time and energy on > > discussion. I hope we can embrace the "there's more than one way to do > > it" ethos in our community. > > That's fine. However, the larger the change, the more risk that > building consensus for merge to master is going to take longer and > potentially not be achieved. Jérôme's recommend process for major > change is one way to mitigate this risk. The note from the > unconference for working code and tests that demonstrate how the > change fulfills goals laid out in a vision doc, is another way. > > > > > >> I'm not sure it would be easy to split this evolution into multiple > smallest pull requests but I'm sure it would be a lot of work. > > > > It will not be easy, but I've come around that it's necessary. I > > propose to close the existing pull request and refactor the work into > > a larger number of smaller commits on a feature branch in the Jasig > > repository. I will ensure that each commit message has some kind of > > keyword to point to the high-level feature it supports, like "MFA," > > "LPPE," etc where applicable, and a meaningful, thoughtful commit > > message otherwise. This will facilitate a high level description of > > changes by looking at the changelog: > > > > git log --oneline START..HEAD > > > > Where START is the common ancestor between master and the feature > > branch. I will post the output of that command in the pull request for > > convenience. > > +1 for improved commits and a feature-branch this for work. > > Best, > Bill > > > > > > I have no intention of producing any further documentation by myself, > > but I'm open to collaborating on documentation. > > > > I would like to vote on this matter. If tightening up the commits on > > another pull request is sufficient to move forward, please vote yea. > > I'm strongly +1. > > > > M > > > > -- > > You are currently subscribed to [email protected] as: > [email protected] > > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev > > -- > You are currently subscribed to [email protected] as: > [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev > > -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
