I have just merged the latest set of changes on ldaptive and principal
resolvers. I believe the branch on that end is also feature-complete now.
There's one more pull I'd like to consider before we move forward:
https://github.com/Jasig/cas/pull/272
I expect some resistance to yet another component name change, but I
think the related refactoring is truly beneficial. In any case we could
take all, some, or none of it.
Process-wise, I'd like to propose that we bring the branch up to speed
with master, go through a few rounds of cleanup and make sure the code
style is compatible with our conventions by checkstyle. We should next be
able to do one wholesome review and finally bring the changes into master.
I fear that a whole enchilada review would be tedious and provide fairly
little value for the effort. We've reviewed each change thoughtfully and
collaboratively; I'd rather us merge with master once we sign off on
feature completeness.
I'm in favor of code cleanup as soon as possible, but at a convenient
time. I'll be happy that it gets done any time prior to the CAS 4.0
final release date.
M
--
You are currently subscribed to [email protected] as:
[email protected]
To unsubscribe, change settings or access archives, see
http://www.ja-sig.org/wiki/display/JSG/cas-dev
