Hi, I've always seen opensaml as a necessary evil, but indeed, our needs are pretty simple.
I took a look at your major commit: https://github.com/Jasig/java-cas-client/commit/cc465041267a48ef4ade268f8ebbc62f873b29ec. It seems we have a little less code now and it's easier to read. Plus we don't have the opensaml libraries. I'm not sure I would have adviced to spend time on SAML support as we now have the /p3 endpoints, but as you already did the job, I'm +1. Best regards; Jérôme 2015-02-20 15:41 GMT+01:00 Marvin Addison <[email protected]>: > I've been doing a fair bit of client-side CAS work lately, and it's become > apparent that OpenSAML is a huge integration pain when integrating the > client into non-trivial Java webapps. Dragging in dependencies as diverse > as joda-time, velocity, and copious XML libraries is the first and biggest > pain. Beyond that, it's a large, complex library that is a poor fit for our > simple processing needs. We went that route because we had encountered some > problems with XML namespace handling, but in retrospect we should have > simply tightened up on the XML processing. While I wish I could go back in > history and choose that path from the start, I would argue that it's not > too late to go there. I've got a working XPath-based processing solution on > the following branch: > > https://github.com/Jasig/java-cas-client/tree/no-opensaml > > While I think XPath-processing could benefit the CAS protocol components > down the road, the present work only touches SAML and support components. > (One small exception: I removed an XML parser configuration parameter that > is no longer relevant.) I would appreciate review and feedback. While I'm > committed to this solution regardless because of an internal project, I'd > like to submit a pull request to master since I think it's generally > beneficial. > > M > > -- > You are currently subscribed to [email protected] as: [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/cas-dev > > -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/cas-dev
