Joao,

thanks for your offer, Please see inline for help ...

Werner


On Wed, 17 Mar 2004 18:31:44 +0000, Joao Luis Pinto wrote:

>
>Dear all
>
>I got the latest version of the code from CVS with Eclipse 
>(http://www.eclipse.org), and noticed a few problems:
>
>- File src/tools/ide/eclipse/classpath.template has not been updated to the 
>latest versions of the distributed .jars . Namely, it lists adaptx_0.9.7.jar 
>while adaptx_0.9.10.jar is distributed and includes both ant 1.4 and 1.5 
>(?), while only 1.5 is distributed.

As I am the one wh checked this in, I'll fix this myself. Can you please open a bug 
report for traceability ?

>- The comment on top of the ant build.xml file is stale, since now ant 1.5 
>is distributed.
>
>- Should ant target "prepare-eclipse" depend on "prepare"? From the list of 
>"prepare" actions, I see no one that matters for the use of Eclipse, while 
>empty and useless (for Eclipse) "build", "classes", "dist" and "schema" 
>folders are created. Couldn't this dependency be dropped?

Please include this with the above bug report, and it shall be changed.
>
>- Compiling all the classes in Eclipse (using the Eclipse builder, not ant) 
>returns around 3000 warnings, between unused imports, wrong javadoc tags, 
>deprecations and all. I'm volunteering to help on the cleanup (minus 
>deprecations), so I would like to know if you're interested, and if so how 
>do you want me to submit the "cleaned" code. 

Your help would be much appreciated here. This is not to say that thsi si not being 
addressed. But after some discussions, we (the current set of JDO 
committers) decided to not clean this up as one major effort, but to clean up code we 
have to touch anyhow as a result of bug fixing, refactoring, etc. 
But this should not prevent you from sending us valid CVS patches and attaching them 
to bug reports (marked as enhancement requets). Does this 
address your question ?

>What is required for CVS commit access?
Well, a history of making (useful) contributions to the project ... and you'll soon be 
granted CVS access by the current committers, if you wish so. Be 
default, only these committers have full access to the CVS repository.

>- Are there any coding conventions on the project?
Yes, there are. Please look at 

http://castor.exolab.org/cvs.html#Guidelines-For-Code-Contribution 

and 

http://castor.exolab.org/cvs.html#Guidelines-For-Committers

for some initial thoughts. An addition, if you check out the code, in src/docs you'll 
find ExolabJavaCoding.pdf.

 If so, perhaps a Code 
>Formatting settings file could be destributed in the eclipse help folder 
>(usable from current Eclipse 3.0M7).
Can you push this my way ... I'd consider adding this to the eclipse folder.

>Any thoughts?
>
>Joćo Luis
>
>_________________________________________________________________
>Help STOP SPAM with the new MSN 8 and get 2 months FREE*  
>http://join.msn.com/?page=features/junkmail
>
>----------------------------------------------------------- 
>If you wish to unsubscribe from this mailing, send mail to
>[EMAIL PROTECTED] with a subject of:
>        unsubscribe castor-dev
>

----------------------------------------------------------- 
If you wish to unsubscribe from this mailing, send mail to
[EMAIL PROTECTED] with a subject of:
        unsubscribe castor-dev

Reply via email to