On 1/30/07, Tobias Kremer <[EMAIL PROTECTED]> wrote:
> I was just looking at this last week, as I was using the code as a
> basis for a new controller. I suspect that it's never been tested,
> because as far as I can tell, it incorrectly reads the config from the
> controller object, rather than the application object.

Yeah, I stumbled across this the other day but was unsure if it was
done on purpose (for a controller-specific configuration rather than a
global config). Nevertheless I found it awkward and IMHO it should be changed.

--Tobias

It was done somewhat on purpose since configuring it via the
controller was how I use it. I would be happy to accept a patch to
make it read from both places.  Just make sure existing tests continue
to pass and work off the version that's up on subversion at
http://dev.catalyst.perl.org/repos/Catalyst/trunk/Catalyst-Controller-FormBuilder/

_______________________________________________
List: Catalyst@lists.rawmode.org
Listinfo: http://lists.rawmode.org/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.rawmode.org/
Dev site: http://dev.catalyst.perl.org/

Reply via email to