Hi Jacek, Danny,

Many thanks for the patch.
Could you please answer a few questions I have, before
we commit this?

+#ifndef _WIN32_WCE
  typedef struct _devicemodeW {
    WCHAR   dmDeviceName[CCHDEVICENAME];
    WORD   dmSpecVersion;
@@ -1574,6 +1585,37 @@
  #endif
  #endif /* WINVER >= 0x0400 */
  } DEVMODEW,*LPDEVMODEW,*PDEVMODEW;
+#else /* _WIN32_WCE */
+typedef struct _devicemodeW {
+  WCHAR  dmDeviceName[CCHDEVICENAME];
+  WORD   dmSpecVersion;
+  WORD   dmDriverVersion;
+  WORD   dmSize;
+  WORD   dmDriverExtra;
+  DWORD  dmFields;
+  short  dmOrientation;
+  short  dmPaperSize;
+  short  dmPaperLength;
+  short  dmPaperWidth;
+  short  dmScale;
+  short  dmCopies;
+  short  dmDefaultSource;
+  short  dmPrintQuality;
+  short  dmColor;
+  short  dmDuplex;
+  short  dmYResolution;
+  short  dmTTOption;
+  short  dmCollate;
+  WCHAR  dmFormName[CCHFORMNAME];
+  WORD   dmLogPixels;
+  DWORD  dmBitsPerPel;
+  DWORD  dmPelsWidth;
+  DWORD  dmPelsHeight;
+  DWORD  dmDisplayFlags;
+  DWORD  dmDisplayFrequency;
+  DWORD  dmDisplayOrientation;
+} DEVMODEW,*PDEVMODEW,*NPDEVMODEW,*LPDEVMODEW;
+#endif /* _WIN32_WCE */

I don't see anything fundamentally different on the non-CE version,
or are the _ANONYMOUS_UNION/_ANONYMOUS_STRUCT not doing their job?

Couldn't you fold them?  There are already some field disabled for
some Windows versions, so I guess you could do the same, eg, for
it reads ...

#if(WINVER >= 0x0400)
   DWORD  dmICMMethod;

... you could change it to:

#if (WINVER >= 0x0400) && !defined (_WIN32_WCE)
   DWORD  dmICMMethod;

Cheers,
Pedro Alves


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Cegcc-devel mailing list
Cegcc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cegcc-devel

Reply via email to