On Apr 11, 2012, at 11:22 AM, Yehuda Sadeh Weinraub wrote:

> Also need to check that cmount is initialized.  I'd add a helper:
> 
> Client *ceph_get_client(struct ceph_mount_info *cmont)
> {
>  if (cmount && cmount->is_mounted())
>    return cmount->get_client();
> 
>  return NULL;
> }

How useful is checking cmount != NULL here? This defensive check depends on 
users initializing their cmount pointers to NULL, but the API doesn't do 
anything to require this initialization assumption.

- Noah--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to