On Fri, Aug 29, 2014 at 6:18 AM, Jon Roelofs <[email protected]>
wrote:

> ================
> Comment at: src/Unwind/Unwind-EHABI.cpp:223
> @@ +222,3 @@
> +    *len = (((data[1] >> 24) & 0xff) + 1) * 4;
> +    data++; // Skip the first word, which is the prel31 offset.
> +  } else {
> ----------------
> piman wrote:
> > Mmh, this makes assumptions about the personality routine doesn't it?
> > The generic model is supposed to be compatible with a variety of
> languages and I'm not sure we can assume the generic data is the same as
> what the C++ personality routine expects, can we?
> In the generic model, the unwind opcodes come first, and then the LSDA
> comes after... this looks correct to me.
>

Where in the EHABI spec is that defined? AFAICT all it says in section 6.2
is that there's data for the PR, but it doesn't say anything about the
contents of that data.


> http://reviews.llvm.org/D5112
>
>
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to