I'd still like to see some test cases added (like the ones I mentioned before),
as well as the changes needed to config.py, lit.site.in, CMakeLists.txt, etc.
so that this can be tested on platforms that **do** have the global filesystem
namespace. Then it should be simple to add another buildbot that checks these,
without having to get a CloudABI buildbot running (I understand that's part of
your plan, this keeps them from bit-rotting in the meantime).
Also, since you're basically marking everything in
test/std/input.output/file.streams/fstreams/ as unsupported, it would be better
to add:
test/std/input.output/file.streams/fstreams/lit.local.cfg
test/std/localization/locales/locale.convenience/conversion/conversions.buffer/lit.local.cfg
with this in them:
if 'libcpp-has-no-global-filesystem-namespace' in config.available_features:
config.unsupported = True
rather than putting `// UNSUPPORTED:`s everywhere. They get yucky to maintain
when other folks add new test files, and this is a mistake I made when I did
the ones for the single-threaded stuff... I still need to fix that. Sorry I
didn't mention this earlier.
Cheers,
Jon
http://reviews.llvm.org/D8194
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
