REPOSITORY rL LLVM ================ Comment at: libcxx/trunk/test/libcxx/test/format.py:63 @@ -62,1 +62,3 @@ + if test.config.unsupported: + return (lit.Test.UNSUPPORTED, ---------------- EricWF wrote: > jroelofs wrote: > > EricWF wrote: > > > I don't think we should be using this. Why not put the metadata into the > > > tests? > > This is how the tests in llvm/test/CodeGen work. I think it cleans things > > up **significantly**. I view it as a mistake that I did the > > libcpp-has-no-threads UNSUPPORTEDs this way.... it's a bit painful to > > maintain them. > My concern is that we accidentally don't run tests because they were > mistakenly put in a directory with a lit.site.cfg that marks all the tests as > unsupported. > > I also think that lit.TestRunner.parseIntegratedTestScript may already handle > this but I'll have to double check. > My concern is that we accidentally don't run tests because they were > mistakenly put in a directory with a lit.site.cfg that marks all the tests as > unsupported.
`--show-unsupported` takes care of that, no? > I also think that lit.TestRunner.parseIntegratedTestScript may already handle > this but I'll have to double check. Apparently not, or there's some flag that I missed that makes it happen... I debugged it a bit this morning before suggesting these lines to @ed http://reviews.llvm.org/D8194 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
