REPOSITORY rL LLVM ================ Comment at: libcxx/trunk/include/__config:731 @@ +730,3 @@ +// used, as they attempt to access the global filesystem namespace. +#ifdef __CloudABI__ +#define _LIBCPP_HAS_NO_GLOBAL_FILESYSTEM_NAMESPACE ---------------- jroelofs wrote: > EricWF wrote: > > Where do we get the definition for `__CloudABI__` from? > Compiler provides it, just like `__APPLE__` and all the others. Where can I find more information about when Clang defines this macro?
================ Comment at: libcxx/trunk/test/libcxx/test/format.py:63 @@ -62,1 +62,3 @@ + if test.config.unsupported: + return (lit.Test.UNSUPPORTED, ---------------- jroelofs wrote: > EricWF wrote: > > I don't think we should be using this. Why not put the metadata into the > > tests? > This is how the tests in llvm/test/CodeGen work. I think it cleans things up > **significantly**. I view it as a mistake that I did the > libcpp-has-no-threads UNSUPPORTEDs this way.... it's a bit painful to > maintain them. My concern is that we accidentally don't run tests because they were mistakenly put in a directory with a lit.site.cfg that marks all the tests as unsupported. I also think that lit.TestRunner.parseIntegratedTestScript may already handle this but I'll have to double check. ================ Comment at: libcxx/trunk/test/std/input.output/file.streams/c.files/no.global.filesystem.namespace/fopen.fail.cpp:8 @@ +7,3 @@ +// +//===----------------------------------------------------------------------===// + ---------------- jroelofs wrote: > EricWF wrote: > > Add `// UNSUPPORTED: libcpp-has-no-global-filesystem-namespace` > No, unless you meant `// REQUIRES: libcpp-has-no-global-filesystem-namespace`. Yep. My mistake. ================ Comment at: libcxx/trunk/test/std/input.output/file.streams/c.files/no.global.filesystem.namespace/rename.fail.cpp:9 @@ +8,3 @@ +//===----------------------------------------------------------------------===// + +#include <cstdio> ---------------- jroelofs wrote: > EricWF wrote: > > Add `// UNSUPPORTED: libcpp-has-no-global-filesystem-namespace` > No, unless you meant `// REQUIRES: libcpp-has-no-global-filesystem-namespace`. I did. Thank you for the correction. http://reviews.llvm.org/D8194 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
