REPOSITORY rL LLVM ================ Comment at: lib/Driver/ToolChains.cpp:2391 @@ +2390,3 @@ + file_paths.push_back(FilePath + "mipsel-nacl/usr/lib"); + prog_paths.push_back(ProgPath + "bin"); + file_paths.push_back(ToolPath + "mipsel-nacl"); ---------------- should this be mipsel-nacl/bin?
================ Comment at: lib/Driver/ToolChains.cpp:2416 @@ +2415,3 @@ + SmallString<128> P(D.Dir + "/../"); + llvm::sys::path::append(P, "mipsel-nacl/include/c++/v1"); + addSystemInclude(DriverArgs, CC1Args, P.str()); ---------------- it seems wrong to include a C++ path here; I don't think this function is C++ specific? And in any case, is this intended to override -nobuiltininc? ================ Comment at: lib/Driver/Tools.cpp:1184 @@ +1183,3 @@ + + if (Triple.getOS() == llvm::Triple::NaCl) { + CmdArgs.push_back("-mllvm"); ---------------- this part may not be upstreamable since the LLVM part that implements it won't be upstreamable. ================ Comment at: lib/Driver/Tools.cpp:8327 @@ +8326,3 @@ + // without '-lnacl' it prefers symbols from libpthread.a over libnacl.a, + // which is not a desired behaviour here. + // See https://sourceware.org/ml/binutils/2015-03/msg00034.html ---------------- which symbols are causing trouble here, and how? can you give some more detail? I wasn't aware of the difference, but I have an unrelated change that may be affected by it. http://reviews.llvm.org/D10739 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits