chandlerc has commented on the revision "Hooks for custom CompilationDatabase".
The code looks fine, but see my comment below... INLINE COMMENTS lib/Tooling/CustomCompilationDatabase.h:31 What are the semantics of Directory? Which directory will be passed in? That of the file? The project? The working directory? How will we even identify the project directory if we don't have the compilation database file? I think there are some unanswered interface and design questions here. REVISION DETAIL http://llvm-reviews.chandlerc.com/D4 BRANCH google3 REPLY HANDLER ACTIONS Reply to comment, or !reject, !abandon, !reclaim, !resign, !rethink, !unsubscribe, !accept. To: klimek, djasper Cc: cfe-commits, chandlerc _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
